Skip to content

TST: flesh out EA setitem tests #39034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021
Merged

TST: flesh out EA setitem tests #39034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 35 additions & 16 deletions pandas/tests/extension/base/setitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,35 @@


class BaseSetitemTests(BaseExtensionTests):
@pytest.fixture(
params=[
lambda x: x.index,
lambda x: list(x.index),
lambda x: slice(None),
lambda x: slice(0, len(x)),
lambda x: range(len(x)),
lambda x: list(range(len(x))),
lambda x: np.ones(len(x), dtype=bool),
],
ids=[
"index",
"list[index]",
"null_slice",
"full_slice",
"range",
"list(range)",
"mask",
],
)
def full_indexer(self, request):
"""
Fixture for an indexer to pass to obj.loc to get/set the full length of the
object.

In some cases, assumes that obj.index is the default RangeIndex.
"""
return request.param

def test_setitem_scalar_series(self, data, box_in_series):
if box_in_series:
data = pd.Series(data)
Expand Down Expand Up @@ -305,30 +334,20 @@ def test_setitem_preserves_views(self, data):
assert view1[0] == data[1]
assert view2[0] == data[1]

def test_setitem_dataframe_column_with_index(self, data):
def test_setitem_with_expansion_dataframe_column(self, data, full_indexer):
# https://github.com/pandas-dev/pandas/issues/32395
df = expected = pd.DataFrame({"data": pd.Series(data)})
result = pd.DataFrame(index=df.index)
result.loc[df.index, "data"] = df["data"]
self.assert_frame_equal(result, expected)

def test_setitem_dataframe_column_without_index(self, data):
# https://github.com/pandas-dev/pandas/issues/32395
df = expected = pd.DataFrame({"data": pd.Series(data)})
result = pd.DataFrame(index=df.index)
result.loc[:, "data"] = df["data"]
key = full_indexer(df)
result.loc[key, "data"] = df["data"]
self.assert_frame_equal(result, expected)

def test_setitem_series_with_index(self, data):
def test_setitem_series(self, data, full_indexer):
# https://github.com/pandas-dev/pandas/issues/32395
ser = expected = pd.Series(data, name="data")
result = pd.Series(index=ser.index, dtype=object, name="data")
result.loc[ser.index] = ser
self.assert_series_equal(result, expected)

def test_setitem_series_without_index(self, data):
# https://github.com/pandas-dev/pandas/issues/32395
ser = expected = pd.Series(data, name="data")
result = pd.Series(index=ser.index, dtype=object, name="data")
result.loc[:] = ser
key = full_indexer(ser)
result.loc[key] = ser
self.assert_series_equal(result, expected)