Skip to content

TYP/CLN: Use futures annotations in apply #39026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2021
Merged

TYP/CLN: Use futures annotations in apply #39026

merged 2 commits into from
Jan 8, 2021

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@rhshadrach rhshadrach added Typing type annotations, mypy/pyright type checking Clean labels Jan 7, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jan 8, 2021
simonjayhawkins
simonjayhawkins reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhshadrach lgtm

@simonjayhawkins simonjayhawkins merged commit 13d384f into pandas-dev:master Jan 8, 2021
@rhshadrach rhshadrach deleted the apply_future_annotations branch January 9, 2021 01:57
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@rhshadrach @luckyvs1
TYP/CLN: Use futures annotations in apply (pandas-dev#39026)
194cbb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Clean Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @simonjayhawkins