Skip to content

DOC: Add whatsnew #39014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021
Merged

DOC: Add whatsnew #39014

merged 1 commit into from
Jan 8, 2021

Conversation

vangorade
Copy link
Contributor

@vangorade vangorade changed the title Add whatsnew DOC: Add whatsnew Jan 7, 2021
@MarcoGorelli
Copy link
Member

Thanks @vangorade - can you rebase so as to drop the unrelated commits please?

@vangorade
Copy link
Contributor Author

did i just messed up something @MarcoGorelli?

@vangorade vangorade changed the base branch from master to 0.19.x January 7, 2021 14:41
@vangorade vangorade changed the base branch from 0.19.x to master January 7, 2021 14:41
@MarcoGorelli
Copy link
Member

possibly :) no worries though - at this point I think the easiest thing might be to just do

git fetch upstream --prune
git reset --hard upstream/master
<make the same changes you'd made previously>
git add -u
git commit -m <commit message>
git push origin HEAD -f

@vangorade
Copy link
Contributor Author

vangorade commented Jan 8, 2021

possibly :) no worries though - at this point I think the easiest thing might be to just do

git fetch upstream --prune
git reset --hard upstream/master
<make the same changes you'd made previously>
git add -u
git commit -m <commit message>
git push origin HEAD -f

Thanks :). I thought i broke something, after some google search i learned about this issue and how to time travel in git and thanks to your reply i finally resolve this issue 👍 !

@MarcoGorelli MarcoGorelli self-requested a review January 8, 2021 11:43
@jreback jreback added the Docs label Jan 8, 2021
@jreback jreback added this to the 1.3 milestone Jan 8, 2021
@jreback jreback merged commit 6259b5a into pandas-dev:master Jan 8, 2021
@jreback
Copy link
Contributor

jreback commented Jan 8, 2021

thanks @vangorade

@vangorade vangorade deleted the add_whatsnew branch January 10, 2021 11:00
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unexpected typecast on datetime.date in groupby.key()
3 participants