CLN: inspect_excel_format #39008
Merged
CLN: inspect_excel_format #39008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Jan 6, 2021
pandas/io/excel/_base.py
Outdated
| @@ -906,24 +906,18 @@ def close(self): | |||
|
|
|||
| @doc(storage_options=_shared_docs["storage_options"]) | |||
| def inspect_excel_format( | |||
| path: Optional[str] = None, | |||
| content: Union[None, BufferedIOBase, RawIOBase, bytes] = None, | |||
| content_or_path: Union[None, str, BufferedIOBase, RawIOBase, IO[bytes]] = None, | |||
There was a problem hiding this comment.
I don't think the default value or type None is necessary here, is that right?
pandas/io/excel/_base.py
Outdated
| if isinstance(content, bytes): | ||
| content_or_path = BytesIO(content) | ||
| else: | ||
| content_or_path = content or path | ||
| assert content_or_path is not None |
There was a problem hiding this comment.
With the above, would be okay to remove this line.
jreback
requested changes
Jan 6, 2021
pandas/io/excel/_base.py
Outdated
| @@ -906,24 +906,18 @@ def close(self): | |||
|
|
|||
| @doc(storage_options=_shared_docs["storage_options"]) | |||
| def inspect_excel_format( | |||
| path: Optional[str] = None, | |||
| content: Union[None, BufferedIOBase, RawIOBase, bytes] = None, | |||
| content_or_path: Union[None, str, BufferedIOBase, RawIOBase, IO[bytes]] = None, | |||
There was a problem hiding this comment.
could just be Buffer? (and I would call the arg buffer)
|
Thanks @lithomas1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rhshadrach