BUG: fix unicode -> str cast in tslib #3900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the other error created is #3899 |
This should use format since calling str on a unicode string is a *bad* idea because it may or may not repr correctly.
|
@jreback this is ready 2 go can i merge? |
|
how was this breaking? |
|
when the |
|
this was also hiding the infinite recursion bug |
|
ok then |
cpcloud
added a commit
that referenced
this pull request
Jun 15, 2013
BUG: fix unicode -> str cast in tslib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should use format since calling str on a unicode string is a bad idea
because it may or may not repr correctly.
closes #3875.
another error is created from fixing this issue.