Skip to content

DOC: add more sections to spreadsheet comparison #38993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 6, 2021

Conversation

afeld
Copy link
Member

@afeld afeld commented Jan 6, 2021

Preview (link to PDF on Google Drive)

This pull request gets closer to full parity with SAS/STATA comparison pages by adding the Data Input/Output through Merging sections. It still needs Missing Data and GroupBy, but wanted to get this in while I was at a good stopping place. Each section was done in its own commit, if it's easier to review that way.


@afeld afeld added the Docs label Jan 6, 2021
@@ -1,4 +1,4 @@
pandas provides similar vectorized operations by specifying the individual ``Series`` in the
pandas provides vectorized operations by specifying the individual ``Series`` in the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This include is now used in the SAS, Stata, and spreadsheet pages. Since spreadsheets don't have "vectorized operations" in the same way, took out this reference.



Finding position of substring
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like these substring operations are that common in spreadsheets, but included them for parity with the SAS and Stata docs. Thoughts about taking them out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you. you (and your students) are the audience. that said, but ok to include.

@@ -117,21 +371,6 @@ This can be achieved by creating a series and assigning it to the desired cells.

df

Filters
~~~~~~~
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved under Data Operations.

@@ -173,81 +412,35 @@ The equivalent in pandas:
tips, values="tip", index=["size"], columns=["sex"], aggfunc=np.average
)

Formulas
~~~~~~~~
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved up to become the Operations on Columns section.


VLOOKUP
~~~~~~~
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved up to be the Merging section.

Old example was referencing a no-longer-existent variable. Switched to
use `append()` rather than `loc`.
[flake8-rst was complaining about `invalid
syntax`](https://github.com/pandas-dev/pandas/pull/38993/checks?check_run_id=1654170719#step:4:67),
meaning it was presumably parsing the block as Python.

::

=LEN(TRIM(A2))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, Pygments doesn't have support for Excel formulas (pygments/pygments#1664) and flake8-rst seems to interpret code-blocks without a language specified as Python, so included the Excel formulas as literal blocks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@jreback jreback added this to the 1.3 milestone Jan 6, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. yeah it would be great if the CI rendered things for us (I see you opened an issue).


::

=LEN(TRIM(A2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm



Finding position of substring
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you. you (and your students) are the audience. that said, but ok to include.

@jreback jreback merged commit 6e20dae into pandas-dev:master Jan 6, 2021
@jreback
Copy link
Contributor

jreback commented Jan 6, 2021

thanks @afeld love the documentation! keep em coming

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants