Skip to content

BUG: Datetimelike equality comparisons with Categorical #38986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 8, 2021
Merged

BUG: Datetimelike equality comparisons with Categorical #38986

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1fb45d8
pandas-dev issue #30699
ftrihardjo Jan 6, 2021
bc39015
pandas-dev issue #30699
ftrihardjo Jan 6, 2021
da043ac
pandas-dev issue #30699
ftrihardjo Jan 6, 2021
156b0cb
pandas-dev issue #30699
ftrihardjo Jan 7, 2021
949cbd7
pandas-dev issue #30699
ftrihardjo Jan 8, 2021
613a3cb
pandas-dev issue #30699
ftrihardjo Jan 8, 2021
3e71711
pandas-dev issue #30699
ftrihardjo Jan 8, 2021
8a163a4
pandas-dev issue #30699
ftrihardjo Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pandas/tests/arrays/test_datetimelike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,20 @@ def test_compare_len1_raises(self):
with pytest.raises(ValueError, match="Lengths must match"):
idx <= idx[[0]]

@pytest.mark.parametrize(
"result",
[
pd.date_range("2020", periods=3),
pd.date_range("2020", periods=3, tz="UTC"),
pd.timedelta_range("0 days", periods=3),
pd.period_range("2020Q1", periods=3, freq="Q"),
],
)
def test_compare_with_Categorical(self, result):
expected = pd.Categorical(result)
assert all(result == expected)
assert not any(result != expected)

@pytest.mark.parametrize("reverse", [True, False])
@pytest.mark.parametrize("as_index", [True, False])
def test_compare_categorical_dtype(self, arr1d, as_index, reverse, ordered):
Expand Down