Skip to content

TST: test fixes for various builds (debian) #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2013

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jun 13, 2013

TST: json tests to int64 to avoid dtype issues, closes #3895
TST: skip tests if xlrd has lower than needed version, closes #3897
TST: skip pickle tests on not-little endianess , closes #3894
TST: skip test_encoding on non-little endian in test_pytables , closes #3892
TST: skip some stata tests on non-little endian, closes #3896

@@ -16,6 +17,9 @@
from pandas.sparse.tests import test_sparse
from pandas.util import py3compat

if sys.byteorder != 'little':
raise nose.SkipTest('system byteorder is not little!')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but isn't it more of a KnownFailure than just a skip? ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a better way to indicate a known failure?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have forgotten why this one is not used any longer:

(sid)root@vagus:/home/yoh/deb/gits/pkg-exppsy/pandas# git grep KnownFailure
pandas/util/decorators.py:class KnownFailureTest(Exception):
pandas/util/decorators.py:    Make function raise KnownFailureTest exception if given condition is true.
pandas/util/decorators.py:        Message to give on raising a KnownFailureTest exception.
pandas/util/decorators.py:                raise KnownFailureTest(msg)

but also look e.g. at https://github.com/numpy/numpy/blob/master/doc/TESTS.rst.txt#known-failures-skipping-tests

jreback added a commit that referenced this pull request Jun 14, 2013
TST: test fixes for various builds (debian)
@jreback jreback merged commit cca1b7e into pandas-dev:master Jun 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment