REF: move functions out of _testing/__init__ #38961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 5, 2021
| @@ -0,0 +1,405 @@ | |||
| import bz2 | |||
There was a problem hiding this comment.
why _io.py? this is already a private module.
| @@ -0,0 +1,48 @@ | |||
| import string | |||
|
|
|||
| import numpy as np | |||
| @@ -0,0 +1,174 @@ | |||
| from contextlib import contextmanager | |||
| import re | |||
jreback
reviewed
Jan 5, 2021
| @@ -55,6 +39,22 @@ | |||
| Series, | |||
| bdate_range, | |||
| ) | |||
| from pandas._testing._io import ( # noqa:F401 | |||
|
BC we don’t have __all__
…On Mon, Jan 4, 2021 at 4:18 PM Jeff Reback ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/_testing/__init__.py
<#38961 (comment)>:
> @@ -55,6 +39,22 @@
Series,
bdate_range,
)
+from pandas._testing._io import ( # noqa:F401
umm why are these ignored?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38961 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6CAIQ743IMYOMEU353SYJLFBANCNFSM4VT2H3HA>
.
|
|
Pet peeve for overlap with stdlib names
…On Mon, Jan 4, 2021 at 4:17 PM Jeff Reback ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In pandas/_testing/_io.py
<#38961 (comment)>:
> @@ -0,0 +1,405 @@
+import bz2
why _io.py? this is *already* a private module.
------------------------------
In pandas/_testing/_random.py
<#38961 (comment)>:
> @@ -0,0 +1,48 @@
+import string
+
+import numpy as np
same comment
------------------------------
In pandas/_testing/_warnings.py
<#38961 (comment)>:
> @@ -0,0 +1,174 @@
+from contextlib import contextmanager
+import re
same
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38961 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6HNABZZN22RJKZIIDTSYJLCFANCNFSM4VT2H3HA>
.
|
jreback
approved these changes
Jan 5, 2021
should add :-> |
i think once we get the implementations out of this file |
jreback
reviewed
Jan 5, 2021
| @@ -214,3 +216,32 @@ def use_numexpr(use, min_elements=None): | |||
| yield | |||
| expr._MIN_ELEMENTS = oldmin | |||
| expr.set_use_numexpr(olduse) | |||
|
|
|||
|
|
|||
| class RNGContext: | |||
There was a problem hiding this comment.
prob should be in _random.py
|
thanks followon comment |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.