ENH: Add support to import optional submodule and specify different min_version than default #38925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
reviewed
Jan 3, 2021
jreback
requested changes
Jan 3, 2021
jreback
reviewed
Jan 3, 2021
| @@ -58,7 +60,11 @@ def _get_version(module: types.ModuleType) -> str: | |||
|
|
|||
|
|
|||
| def import_optional_dependency( | |||
There was a problem hiding this comment.
i believe we could / should min_version in the codebase, but can be a followon
| @@ -85,7 +90,9 @@ def import_optional_dependency( | |||
| * ignore: Return the module, even if the version is too old. | |||
| It's expected that users validate the version locally when | |||
| using ``on_version="ignore"`` (see. ``io/html.py``) | |||
|
|
|||
| min_version : str, default None | |||
There was a problem hiding this comment.
can you create an issue (and PR!) to consolidate raise_on_missing / on_version which really should just be errors='raise|warn|ignore'
5 tasks
jreback
approved these changes
Jan 4, 2021
|
thanks @lithomas1 ok this is not actually running anywhere, can you use this wherever we actually use a min_version |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…in_version than default (pandas-dev#38925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffcc @jreback, @arw2019