REF: de-duplicate code in libparsing/libperiod #38915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 3, 2021
pandas/_libs/tslibs/parsing.pyx
Outdated
| else: | ||
| month = (quarter - 1) * 3 + 1 | ||
| try: | ||
| # TODO: hack attack, GH#1228 |
There was a problem hiding this comment.
prob can remove the comment now :->
| @@ -74,8 +74,7 @@ from pandas._libs.tslibs.dtypes cimport ( | |||
| PeriodDtypeBase, | |||
| attrname_to_abbrevs, | |||
| ) | |||
| from pandas._libs.tslibs.parsing cimport get_rule_month | |||
|
|
|||
| from pandas._libs.tslibs.parsing cimport quarter_to_myear | |||
There was a problem hiding this comment.
prob can cimport parse_time_string too
jreback
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff