BUG: casting on concat with empties #38907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Jan 3, 2021
| @@ -318,6 +318,12 @@ def _concatenate_join_units( | |||
| # Concatenating join units along ax0 is handled in _merge_blocks. | |||
| raise AssertionError("Concatenating join units along axis0") | |||
|
|
|||
| nonempties = [ | |||
| x for x in join_units if x.block is None or x.block.shape[concat_axis] > 0 | |||
There was a problem hiding this comment.
consider having a method on block for this
jreback
added
Dtype Conversions
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jan 8, 2021
This reverts commit 04282c7.
jreback
pushed a commit
that referenced
this pull request
Jan 8, 2021
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
) * Revert "BUG: casting on concat with empties (pandas-dev#38907)" This reverts commit 04282c7. * Revert "BUG: inconsistent concat casting EA vs non-EA (pandas-dev#38843)" This reverts commit 2362df9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffCovers the case missed by #38843