Skip to content

TST/REF: split io/parsers/test_common into multiple files #38897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

arw2019
Copy link
Member

@arw2019 arw2019 commented Jan 2, 2021

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Another precursor to #38370

@arw2019
Copy link
Member Author

arw2019 commented Jan 2, 2021

On this branch:

(pandas-dev) andrewwieteska@Andrews-MacBook-Pro pandas % pytest pandas/tests/io/parser/common/
============================================================= test session starts =============================================================
platform darwin -- Python 3.8.6, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
rootdir: /Users/andrewwieteska/repos/pandas, configfile: setup.cfg
plugins: forked-1.2.0, xdist-2.1.0, cov-2.10.1, asyncio-0.14.0, hypothesis-5.41.2, instafail-0.4.1
collected 646 items                                                                                                                           

pandas/tests/io/parser/common/test_chunksize.py .......................................XXX............                                  [  8%]
pandas/tests/io/parser/common/test_common_basic.py ................s................................................................... [ 21%]
........................................................................................                                                [ 34%]
pandas/tests/io/parser/common/test_data_list.py ............                                                                            [ 36%]
pandas/tests/io/parser/common/test_decimal.py .........                                                                                 [ 38%]
pandas/tests/io/parser/common/test_file_buffer_url.py ................................................................................. [ 50%]
................................................                                                                                        [ 58%]
pandas/tests/io/parser/common/test_float.py .............................................                                               [ 65%]
pandas/tests/io/parser/common/test_index.py ................................................                                            [ 72%]
pandas/tests/io/parser/common/test_inf.py ...............                                                                               [ 74%]
pandas/tests/io/parser/common/test_ints.py ............................................................                                 [ 84%]
pandas/tests/io/parser/common/test_iterator.py .....................                                                                    [ 87%]
pandas/tests/io/parser/common/test_read_errors.py ...........................................................................           [ 99%]
pandas/tests/io/parser/common/test_verbose.py ......                                                                                    [100%]

================================================= 642 passed, 1 skipped, 3 xpassed in 21.19s ==================================================

On master:

(pandas-dev) andrewwieteska@Andrews-MacBook-Pro pandas % pytest pandas/tests/io/parser/test_common.py 
============================================================= test session starts =============================================================
platform darwin -- Python 3.8.6, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
rootdir: /Users/andrewwieteska/repos/pandas, configfile: setup.cfg
plugins: forked-1.2.0, xdist-2.1.0, cov-2.10.1, asyncio-0.14.0, hypothesis-5.41.2, instafail-0.4.1
collected 646 items                                                                                                                           

pandas/tests/io/parser/test_common.py ..................................s.............................................................. [ 15%]
........................................................................................................................XXX............ [ 35%]
....................................................................................................................................... [ 56%]
....................................................................................................................................... [ 77%]
....................................................................................................................................... [ 98%]
.........                                                                                                                               [100%]

================================================= 642 passed, 1 skipped, 3 xpassed in 21.49s ==================================================

@arw2019 arw2019 added IO CSV read_csv, to_csv Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Jan 2, 2021
@arw2019 arw2019 closed this Jan 2, 2021
@arw2019 arw2019 reopened this Jan 2, 2021
@jreback jreback added this to the 1.3 milestone Jan 3, 2021
@jreback
Copy link
Contributor

jreback commented Jan 3, 2021

@arw2019 can you merge master once more to make sure recent merges didn't mess this up. ping on green.

@arw2019
Copy link
Member Author

arw2019 commented Jan 4, 2021

Green

@jreback jreback merged commit f6aec03 into pandas-dev:master Jan 4, 2021
@jreback
Copy link
Contributor

jreback commented Jan 4, 2021

thanks

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants