-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Series.update with categorical #38873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
16c2001
pandas-dev issue #25744
ftrihardjo 4c27fda
Merge remote-tracking branch 'origin/master'
ftrihardjo 6e3176e
pandas-dev issue #27338
ftrihardjo 0d2df96
pandas-dev issue #25744
ftrihardjo bcc927a
pandas-dev issue #25744
ftrihardjo 1e2561f
pandas-dev issue #27338
ftrihardjo e8d0bbc
pandas-dev issue #25744
ftrihardjo f7958fe
pandas-dev issue #25744
ftrihardjo ff64571
pandas-dev issue #25744
ftrihardjo dfc92bb
pandas-dev issue #25744
ftrihardjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,3 +108,11 @@ def test_update_from_non_series(self, series, other, expected): | |
def test_update_extension_array_series(self, result, target, expected): | ||
result.update(target) | ||
tm.assert_series_equal(result, expected) | ||
def test_update_with_categorical_type(self): | ||
# GH 25744 | ||
t = CategoricalDtype(['a', 'b', 'c', 'd']) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. call this dtype |
||
s1 = Series(['a', 'b', 'c'], index=[1, 2, 3], dtype=t) | ||
s2 = Series(['b', 'a'], index=[1, 2], dtype=t) | ||
result = s1.update(s2) | ||
expected = Series(['b', 'a', 'c'], index=[1, 2, 3], dtype=t) | ||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a blank line before the test.