BUG: additional keys in groupby indices when NAs are present #38861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oup_indices � Conflicts: � doc/source/whatsnew/v1.3.0.rst
rhshadrach
added
Bug
Groupby
Missing-data
jreback
requested changes
Dec 31, 2020
pandas/_libs/lib.pyx
Outdated
| if labels[j] != -1: | ||
| break | ||
| else: | ||
| raise ValueError("cannot handle all null values") |
There was a problem hiding this comment.
hmm, just return result no?
There was a problem hiding this comment.
Good call, returning result is much better than raising. Currently no tests can possibly hit this because of short-circuit logic in get_indexer_dict (I changed the comment around it, see the diff), I merely added it to be defensive. Doesn't seem advantageous to remove the short-circuit logic.
There was a problem hiding this comment.
The return of an empty dictionary is hit by several tests however.
|
@jreback thanks for the review; responses above. |
jreback
reviewed
Dec 31, 2020
| start = 0 | ||
| cur = labels[0] | ||
| for i in range(1, n): | ||
| # Start at the first non-null entry |
There was a problem hiding this comment.
I guess L891 is redundant now?
There was a problem hiding this comment.
Yes, it is, thanks. Removed.
jreback
approved these changes
Jan 1, 2021
|
thanks @rhshadrach |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --difflib.indices_fastincluded logic to skip over null values (-1's), but did not include the case where the first index is null. Currently this function is only used insorting.get_indexer_dictwhere the case of all null group_index is handled separately.