BUG: DataFrame(ndarray, dtype=categoricaldtype) #38857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Dec 31, 2020
| # mixed | ||
| df = DataFrame([Categorical(list("abc")), list("def")]) | ||
| expected = DataFrame( | ||
| {0: Series(list("abc"), dtype="category"), 1: list("def")}, columns=[0, 1] | ||
| ) | ||
| tm.assert_frame_equal(df, expected) | ||
|
|
||
| def test_construct_from_listlikes_mismatched_lengths(self): |
There was a problem hiding this comment.
may pay to split out this test file as getting kind of big
There was a problem hiding this comment.
ive been thinking that myself. will address before long
jreback
added
Categorical
|
this broke some things locally, am troubleshooting now |
…f-construction-cat
jreback
requested changes
Jan 1, 2021
…f-construction-cat
|
rebased + green |
jreback
approved these changes
Jan 2, 2021
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
* BUG: DataFrame(ndarray, dtype=categoricaldtype) * whatsnew * GH ref * elif->if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff