Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLD: move metadata to setup.cfg #38852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: move metadata to setup.cfg #38852
Changes from 10 commits
8e9a503
229a7f2
0199b1a
0f737e4
8191bc4
5327578
10f4a4c
5de4991
e9f7b84
ec33ac9
ea10a0f
50edbd8
24c4e29
ffd90a7
b25bf90
e2f83df
75f3e27
2840c65
61a1aef
5752a09
b3e9f3c
e8ab481
0d2a9f1
20da426
3377c1f
5b0a817
de38f59
0fa7b0d
0026b00
21b8797
68e34f3
769ddef
1156724
94c8eff
37e8a82
012f859
20d24b5
94c1de0
e3b0cd2
d2510be
25d1f4a
75e7004
defcccb
27dfd7e
a230b15
b4a8b61
5b614df
674e728
cb757e4
a5d8987
6ae0c56
b227a64
dd75479
424c194
12d360f
a69cf7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could modify PATH and uncomment this line to enable pep517. But I feel that may require some discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems
setup_requires
wasn't added back in setup.cfg? Are there consequences of no longer including it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added workflow pip installs pandas without the requirements pre-installed. Seems to pull in requirements OK. (I also wanted to test with other versions of setuptools locally though before approving this PR)
OT for the sdist build step we do
python setup.py clean --quiet
. This fails if numpy not installed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you installed numpy in that workflow, so the question is maybe what would happen if numpy was not installed? (having the setup_requires might give a nicer error message?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I created 2 different conda environments. so numpy is not in the pip-test environment. (In #36704 the build and test steps are done independently - here I just added a stripped down workflow that we maybe could consider adding permanently to the the ci)