CLN: add typing to dtype arg in selection of files in core/arrays (GH38808) #38826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashpancham
changed the title
jreback
requested changes
Dec 30, 2020
pandas/core/arrays/boolean.py
Outdated
| @@ -273,7 +273,7 @@ def dtype(self) -> BooleanDtype: | |||
|
|
|||
| @classmethod | |||
| def _from_sequence( | |||
| cls, scalars, *, dtype=None, copy: bool = False | |||
| cls, scalars, *, dtype: Optional[DtypeArg] = None, copy: bool = False | |||
There was a problem hiding this comment.
most of these are Optional[Dtype} NOT DtypeArg (eg. only a single dtype and not a dict of them). The only things that take DtypeArg are things like astype and the I/O methods
There was a problem hiding this comment.
Changed it. I did it right last time, but I think I was a bit too quick with submitting this PR. Thanks for the review.
|
Some checks are failing, will look at it tomorrow. |
jreback
requested changes
Dec 30, 2020
pandas/core/arrays/categorical.py
Outdated
| @@ -1294,7 +1297,7 @@ def _validate_fill_value(self, fill_value): | |||
|
|
|||
| # ------------------------------------------------------------- | |||
|
|
|||
| def __array__(self, dtype=None) -> np.ndarray: | |||
| def __array__(self, dtype: Optional[Dtype] = None) -> np.ndarray: | |||
There was a problem hiding this comment.
these should be NpDtype (this is a numpy protocol)
pandas/core/arrays/datetimelike.py
Outdated
| @@ -265,7 +265,7 @@ def _formatter(self, boxed=False): | |||
| # ---------------------------------------------------------------- | |||
| # Array-Like / EA-Interface Methods | |||
|
|
|||
| def __array__(self, dtype=None) -> np.ndarray: | |||
| def __array__(self, dtype: Optional[Dtype] = None) -> np.ndarray: | |||
jreback
approved these changes
Dec 30, 2020
|
lgtm ping on green |
|
thanks @avinashpancham |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on PR for #38808
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff