-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI,STYLE: GH38802 narrow down list of ignored words #38820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chinggg , this looks correct!
Regarding your comment in the closed PR, git
is hard for everyone at the beginning - I found the first 3 chapters of this book to be invaluable in learning it https://git-scm.com/book/en/v2
Will merge when this is green, if you want to try similarly narrowing down other words, then that might well be possible
--
For the future, I'd advise creating a new branch when opening a PR, see the contributing guide https://pandas.pydata.org/pandas-docs/dev/development/contributing.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to go back on this, but I think we can do better
The changes you've made for datas
are fine, but it might be better to reverse the ones for fox/nox
, as fox
as at least is a real animal.
The way to do that is:
- add a new file called
.codespellignorelines
- in that file, add the following:
1 fo
- in
setup.cfg
, add the following to the codespell section so it looks like this:
[codespell]
ignore-words-list=ba,blocs,coo,hist,nd,ser
exclude-file=.codespellignorelines
Like this, it should be possible to get rid of some other words to ignore, such as ba
. nd
and hist
are pretty common, and make sense to keep, but those like ba
that just appear sporadically we could add to the .codespellignorelines
file
Do let me know if any of this is unclear or if you want/need help with git commands
Thanks a lot for explaining patiently!
|
Sure, that's fine, thanks! And yes, I agree with your assessment of which words to keep in |
Closing this one in favour of the new PR then |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff