Skip to content

BUG: allow itertuples to work with frames with duplicate column names #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2013
Merged

BUG: allow itertuples to work with frames with duplicate column names #3879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06a154f
BUG: allow itertuples to work with duplicate columns
cpcloud Jun 13, 2013
e7addae
DOC: add release notes and bug fix notes
cpcloud Jun 13, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASE.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,8 @@ pandas 0.11.1
- ``read_html`` now correctly skips tests (GH3741_)
- Fix incorrect arguments passed to concat that are not list-like (e.g. concat(df1,df2)) (GH3481_)
- Correctly parse when passed the ``dtype=str`` (or other variable-len string dtypes) in ``read_csv`` (GH3795_)
- ``DataFrame.itertuples()`` now works with frames with duplicate column
names (GH3873_)

.. _GH3164: https://github.com/pydata/pandas/issues/3164
.. _GH2786: https://github.com/pydata/pandas/issues/2786
Expand Down Expand Up @@ -314,6 +316,7 @@ pandas 0.11.1
.. _GH3795: https://github.com/pydata/pandas/issues/3795
.. _GH3814: https://github.com/pydata/pandas/issues/3814
.. _GH3834: https://github.com/pydata/pandas/issues/3834
.. _GH3873: https://github.com/pydata/pandas/issues/3873


pandas 0.11.0
Expand Down
3 changes: 3 additions & 0 deletions doc/source/v0.11.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,8 @@ Bug Fixes

- ``DataFrame.from_records`` did not accept empty recarrays (GH3682_)
- ``read_html`` now correctly skips tests (GH3741_)
- ``DataFrame.itertuples()`` now works with frames with duplicate column
names (GH3873_)

See the `full release notes
<https://github.com/pydata/pandas/blob/master/RELEASE.rst>`__ or issue tracker
Expand Down Expand Up @@ -399,3 +401,4 @@ on GitHub for a complete list.
.. _GH3726: https://github.com/pydata/pandas/issues/3726
.. _GH3425: https://github.com/pydata/pandas/issues/3425
.. _GH3834: https://github.com/pydata/pandas/issues/3834
.. _GH3873: https://github.com/pydata/pandas/issues/3873
4 changes: 3 additions & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,9 @@ def itertuples(self, index=True):
arrays = []
if index:
arrays.append(self.index)
arrays.extend(self[k] for k in self.columns)

# use integer indexing because of possible duplicate column names
arrays.extend(self.iloc[:, k] for k in xrange(len(self.columns)))
return izip(*arrays)

iterkv = iteritems
Expand Down
4 changes: 4 additions & 0 deletions pandas/tests/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3951,6 +3951,10 @@ def test_itertuples(self):
for tup in df.itertuples(index=False):
self.assert_(isinstance(tup[1], np.integer))

df = DataFrame(data={"a": [1, 2, 3], "b": [4, 5, 6]})
dfaa = df[['a', 'a']]
self.assertEqual(list(dfaa.itertuples()), [(0, 1, 1), (1, 2, 2), (2, 3, 3)])

def test_len(self):
self.assertEqual(len(self.frame), len(self.frame.index))

Expand Down