Iloc truncates single-column dataframe with extension arrays #38750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Dec 28, 2020
| df = DataFrame({"A": [1] * 10}) | ||
| df = df.iloc[:, :5] | ||
| expected = np.array([10, 1]) | ||
| tm.assert_equal(np.array(df.shape), expected) |
There was a problem hiding this comment.
I think the issue only appears for ExtensionArray. I'd guess that the behavior you're testing for here is, in some shape or form, tested for already, just not with an ExtensionArray. Can you check?
Also, as reported in the original issue, df.shape returns the expected result but df.values.shape does not. Both should be tested (again, for EAs).
jreback
requested changes
Dec 28, 2020
| @@ -875,6 +875,13 @@ def test_iloc_setitem_dictionary_value(self): | |||
| expected = DataFrame({"x": [1, 9], "y": [2.0, 99.0]}) | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
| def test_iloc_truncate_data_wrong_axis_single_column(self): | |||
| # GH30263 | |||
There was a problem hiding this comment.
also can you add the example from the OP exactly
jreback
added
ExtensionArray
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
closing as stale. if you want to continue, pls ping and can re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test to ensure .iloc does not truncate data for a single-column dataframe with an extension array, as discussed in GH30263.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff