Revert "TST: Bare pytest raises" in base extension tests #38748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9919623.
jorisvandenbossche
added
the
Testing
|
@MarcoGorelli on the PR you mentioned " |
Yes, that's right - I was just asking about what should be done in the future about these tests once it is checked in CI. Also, does |
|
I don't have a strong preference. I can also add |
|
thanks @jorisvandenbossche |
4 tasks
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…38748) * Revert "TST: Bare pytest raises (pandas-dev#38576)" This reverts commit 9919623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #38576, see discussion there. We should not add detailed error message asserts, as those tests are also used by external packages, that might have different error messages.