Skip to content

CLN: remove duplicate banklist.html file #38739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

afeld
Copy link
Member

@afeld afeld commented Dec 28, 2020

Wasn't quite a duplicate — had a missing <tr>. Also updated the .gitignore to more accurately only exclude HTML files from doc/source/_static/, since other files are checked in.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@@ -2459,7 +2459,7 @@ as a string:
.. ipython:: python
:suppress:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit strange to me that this part is suppressed while the with open(file_path, "r") below isn't, but I let that be.

@afeld afeld mentioned this pull request Dec 28, 2020
26 tasks
Wasn't quite a duplicate — had a missing <tr>. Also updated the
.gitignore to more accurately only exclude HTML files from
`doc/source/_static/`, since other files are checked in.
@jreback jreback added the Docs label Dec 28, 2020
@jreback jreback added this to the 1.3 milestone Dec 28, 2020
@jreback jreback merged commit c698246 into pandas-dev:master Dec 28, 2020
@jreback
Copy link
Contributor

jreback commented Dec 28, 2020

thanks @afeld

@afeld afeld deleted the static-ignore branch December 29, 2020 00:08
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants