-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: GroupBy.idxmax/idxmin with EA dtypes #38733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4a3f8aa
BUG: GroupBy.idxmax/idxmin with EA dtypes
jbrockmendel 58bc1c5
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel ab441db
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel b9dfbd6
TST: extension test for argmin/argmax with skipna
jbrockmendel 305b934
revert
jbrockmendel 749e74d
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 403951c
whatsnew
jbrockmendel ed7190a
Update doc/source/whatsnew/v1.3.0.rst
jbrockmendel 1d8e28e
update docstring
jbrockmendel 2d31448
Merge branch 'bug-gb-idxmax' of github.com:jbrockmendel/pandas into b…
jbrockmendel 2fd45ad
test for NotImplementedError
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -591,7 +591,7 @@ def argsort( | |
mask=np.asarray(self.isna()), | ||
) | ||
|
||
def argmin(self): | ||
def argmin(self, axis=None, skipna: bool = True): | ||
""" | ||
Return the index of minimum value. | ||
|
||
|
@@ -606,9 +606,11 @@ def argmin(self): | |
-------- | ||
ExtensionArray.argmax | ||
""" | ||
if not skipna: | ||
raise NotImplementedError | ||
jorisvandenbossche marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return nargminmax(self, "argmin") | ||
|
||
def argmax(self): | ||
def argmax(self, axis=None, skipna: bool = True): | ||
""" | ||
Return the index of maximum value. | ||
|
||
|
@@ -623,6 +625,8 @@ def argmax(self): | |
-------- | ||
ExtensionArray.argmin | ||
""" | ||
if not skipna: | ||
raise NotImplementedError | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a test that hits this (and argmin) |
||
return nargminmax(self, "argmax") | ||
|
||
def fillna(self, value=None, method=None, limit=None): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
axis
keyword shouldn't be added, since it's being ignored. It can be accepted through args/kwargs, and then validated with our numpy compat (+ tests for the numpy compat)