Skip to content

TST: GH38718 Tests for casting an interval range from float to int #38719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

TST: GH38718 Tests for casting an interval range from float to int #38719

merged 1 commit into from
Dec 30, 2020

Conversation

moink
Copy link
Member

@moink moink commented Dec 27, 2020

xrefs #38697 , #15832

@moink
TST: GH38718 fix an xfail test and add new test for expected behaviou…
52a9c4d 
…r when casting interval range from float to int
@moink moink mentioned this pull request Dec 27, 2020
Merged
5 tasks
@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Interval Interval data type labels Dec 27, 2020
@jreback jreback added this to the 1.3 milestone Dec 27, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Dec 27, 2020
jreback
jreback approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. cc @jbrockmendel

@jreback
Copy link
Contributor

jreback commented Dec 29, 2020

cc @jbrockmendel

@jbrockmendel
Copy link
Member

LGTM

@jreback jreback merged commit f58d815 into pandas-dev:master Dec 30, 2020
@jreback
Copy link
Contributor

jreback commented Dec 30, 2020

thanks @moink

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@moink @luckyvs1
TST: GH38718 fix an xfail test and add new test for expected behaviou…
00ae71c 
…r when casting interval range from float to int (pandas-dev#38719)
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 2, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Change tests of casting an interval range index from float to int to reflect current behaviour
3 participants
@moink @jreback @jbrockmendel