Skip to content

Updated PULL_REQUEST_TEMPLATE.md #38696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 4, 2021
Merged

Updated PULL_REQUEST_TEMPLATE.md #38696

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5761c9c
Updated PULL_REQUEST_TEMPLATE.md
BobinMathew Dec 25, 2020
797b2ba
Merge pull request #1 from pandas-dev/master
BobinMathew Dec 26, 2020
c3f0487
Added issue number
BobinMathew Dec 26, 2020
13cb90e
Change reverted
BobinMathew Dec 26, 2020
b2277ff
Added link to docs
BobinMathew Dec 31, 2020
df66eab
Removed unwanted spaces
BobinMathew Dec 31, 2020
6ab2f1f
Merge pull request #2 from pandas-dev/master
BobinMathew Dec 31, 2020
3f7fd67
Modified code standards section
BobinMathew Dec 31, 2020
d52c4f4
Reverted one checkbox
BobinMathew Dec 31, 2020
9b5ed55
Removed ``
BobinMathew Dec 31, 2020
93a6ca6
Reverted to 'closes #xxxx'
BobinMathew Jan 3, 2021
23836d2
Removed one "pass" check
BobinMathew Jan 3, 2021
23e20f9
Update contributing.rst
BobinMathew Jan 3, 2021
222c612
Update contributing.rst
BobinMathew Jan 3, 2021
e6c716b
Reverted contributing.rst
BobinMathew Jan 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
- [ ] closes #xxxx
- [ ] closes [#38696](https://github.com/pandas-dev/pandas/issues/38694)
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry
2 changes: 1 addition & 1 deletion doc/source/development/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ Thus, good style is a requirement for submitting code to pandas.
There is a tool in pandas to help contributors verify their changes before
contributing them to the project::

./ci/code_checks.sh
pre-commit run --from-ref=upstream/master --to-ref=HEAD --all-files

The script verifies the linting of code files, it looks for common mistake patterns
(like missing spaces around sphinx directives that make the documentation not
Expand Down