Skip to content

Revert "Deprecated casting an object-dtype index of datetime objects to DatetimeIndex in the Series constructor (23598)" #38679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 25, 2020

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Dec 24, 2020

This partially reverts commit 90a6135.

@simonjayhawkins simonjayhawkins added Regression Functionality that used to work in a prior pandas version Warnings Warnings that appear or should be added to pandas labels Dec 24, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Dec 24, 2020
…ts to :class:`.DatetimeIndex` in the :class:`Series` constructor (:issue:`23598`) only
@simonjayhawkins simonjayhawkins changed the title Revert "DEPR: is_all_dates (#36697)" Revert "Deprecated casting an object-dtype index of datetime objects to DatetimeIndex in the Series constructor (:issue:23598)" Dec 24, 2020
@simonjayhawkins simonjayhawkins changed the title Revert "Deprecated casting an object-dtype index of datetime objects to DatetimeIndex in the Series constructor (:issue:23598)" Revert "Deprecated casting an object-dtype index of datetime objects to DatetimeIndex in the Series constructor (23598)" Dec 24, 2020
@jreback
Copy link
Contributor

jreback commented Dec 24, 2020

fine by me. cc @jbrockmendel

@jbrockmendel
Copy link
Member

If the idea is to un-revert following 1.2, sure.

@simonjayhawkins
Copy link
Member Author

If the idea is to un-revert following 1.2, sure.

from #38182 (comment)

Users should not see unrelated deprecation warnings from the internals of pandas that they can't do anything about themselves, so IMO we should either fix those for 1.2, or delay the deprecationg for 1.3

not fixed, so delaying to 1.3

@jreback jreback merged commit cb7d058 into pandas-dev:master Dec 25, 2020
@jreback
Copy link
Contributor

jreback commented Dec 25, 2020

ok great, thanks @simonjayhawkins

yeah we can unrevert this for 1.3, but i think ok to release once this hits.

@jreback
Copy link
Contributor

jreback commented Dec 25, 2020

@meeseeksdev backport 1.2.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 25, 2020
…ype index of datetime objects to DatetimeIndex in the Series constructor (23598)"
@simonjayhawkins simonjayhawkins deleted the revert-36697 branch December 26, 2020 10:03
simonjayhawkins added a commit that referenced this pull request Dec 26, 2020
…of datetime objects to DatetimeIndex in the Series constructor (23598)" (#38699)

Co-authored-by: Simon Hawkins <[email protected]>
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
…to DatetimeIndex in the Series constructor (23598)" (pandas-dev#38679)

* Revert "DEPR: is_all_dates (pandas-dev#36697)"

This reverts commit 90a6135.

* revert Deprecated casting an object-dtype index of ``datetime`` objects to :class:`.DatetimeIndex` in the :class:`Series` constructor (:issue:`23598`) only

* Revert "BUG: record warnings related to DatetimeIndex (pandas-dev#37193)"

This reverts commit 23c41bd.

* remove assert_produces_warning added in TST/REF: collect tests by method, some misplaced pandas-dev#37354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Functionality that used to work in a prior pandas version Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG/DEPR: Fix unwanted warnings from the Series(Index[datetime objects]) deprecation
3 participants