Skip to content

TST/REF: Delete duplicate hist tests #38628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2020
Merged

TST/REF: Delete duplicate hist tests #38628

merged 1 commit into from
Dec 22, 2020

Conversation

mzeitlin11
Copy link
Member

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

The tests deleted in this pr are also found starting here:

pandas/pandas/tests/plotting/test_hist_method.py

Lines 26 to 27 in e4f425d

def test_hist_legacy(self):
_check_plot_works(self.ts.hist)

@jreback jreback added Testing pandas testing functions or related to the test suite Visualization plotting labels Dec 22, 2020
@jreback jreback added this to the 1.3 milestone Dec 22, 2020
@jreback jreback merged commit ca52e39 into pandas-dev:master Dec 22, 2020
@jreback
Copy link
Contributor

jreback commented Dec 22, 2020

thanks @mzeitlin11 very nice

@mzeitlin11 mzeitlin11 deleted the tst/remove_dup_hist_tests branch December 22, 2020 01:21
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@mzeitlin11 @luckyvs1
TST/REF: delete duplicated hist tests (pandas-dev#38628)
a3c9095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mzeitlin11 @jreback