BUG: join not working correctly with MultiIndex and one dimension categorical #38621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Categorical
pandas/core/indexes/base.py
Outdated
| ) | ||
| ): | ||
| # Categorical is monotonic if data are ordered as categories, but join can | ||
| # not handle this in case of not alphabetically monotonic GH#38502 |
There was a problem hiding this comment.
is alphabetical really the issue? what about numeric or dt64 Categoricals?
There was a problem hiding this comment.
Hm bad wording probably. If the object is lexicographically ordered everything is fine. Monotonic in the sense of categorical monotonic is the problem
There was a problem hiding this comment.
I will add tests for different types of Categorical.s
There was a problem hiding this comment.
Added float, int and timestamps.
Edit: They are all failling without the changes
� Conflicts: � doc/source/whatsnew/v1.3.0.rst � pandas/tests/reshape/merge/test_join.py
jreback
requested changes
Jan 11, 2021
| self.is_monotonic | ||
| and other.is_monotonic | ||
| and ( | ||
| not isinstance(self, ABCMultiIndex) |
There was a problem hiding this comment.
can you check _is_lexsorted instead rather than this specific check.
There was a problem hiding this comment.
Same issue as with is_monotonic, depends on the categories too.
jreback
approved these changes
Jan 13, 2021
|
thanks @phofl |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff