Skip to content

Revert "REF: use astype_nansafe in Index.astype" #38610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2020
Merged

Revert "REF: use astype_nansafe in Index.astype" #38610

merged 2 commits into from
Dec 21, 2020

Conversation

simonjayhawkins
Copy link
Member

Reverts #38518

@simonjayhawkins simonjayhawkins mentioned this pull request Dec 21, 2020
Closed
@simonjayhawkins simonjayhawkins linked an issue Dec 21, 2020 that may be closed by this pull request
REGR: astype(str) of object array with byte objects #38607
Closed
@simonjayhawkins simonjayhawkins added the Regression Functionality that used to work in a prior pandas version label Dec 21, 2020
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Dec 21, 2020
@simonjayhawkins
Copy link
Member Author

may also close #38592, see #38592 (comment)

@jreback
Copy link
Contributor

jreback commented Dec 21, 2020 •
edited
Loading

this is for 1.3? nvm i see

@jreback
Copy link
Contributor

jreback commented Dec 21, 2020

@jbrockmendel ok here ?

@jbrockmendel
Copy link
Member

jbrockmendel commented Dec 21, 2020 via email

@simonjayhawkins
Copy link
Member Author

may also close #38592, see #38592 (comment)

hmm, maybe not.

       before           after         ratio
     [d3c52e4a]       [15daa4c5]
     <master>         <revert-38518-ref-astype-index>
-        9.82±1ms       7.09±0.1ms     0.72  stat_ops.FrameOps.time_op('sem', 'Int64', 0)

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

@jreback jreback merged commit 457df83 into master Dec 21, 2020
@jreback
Copy link
Contributor

jreback commented Dec 21, 2020

thanks @simonjayhawkins

@jbrockmendel might want to rebase any PRs which touch this

@simonjayhawkins simonjayhawkins deleted the revert-38518-ref-astype-index branch December 21, 2020 17:34
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@simonjayhawkins @luckyvs1
Revert "REF: use astype_nansafe in Index.astype" (pandas-dev#38610)
7e4496d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

REGR: astype(str) of object array with byte objects
3 participants
@simonjayhawkins @jreback @jbrockmendel