Skip to content

CLN: Window _constructors definitions #38595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2020
Merged

CLN: Window _constructors definitions #38595

merged 2 commits into from
Dec 21, 2020

Conversation

mroeschke
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Redefined in more appropriate locations.

@mroeschke mroeschke added Clean Window rolling, ewma, expanding labels Dec 20, 2020
@jreback jreback modified the milestones: 1.2.1, 1.3 Dec 21, 2020
@jreback jreback merged commit 8835222 into pandas-dev:master Dec 21, 2020
@jreback
Copy link
Contributor

jreback commented Dec 21, 2020

thanks @mroeschke

@mroeschke mroeschke deleted the cln/window_constructor branch December 21, 2020 18:21
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@mroeschke @luckyvs1
CLN: Define _constructor in window classes when needed (pandas-dev#38595
d7df51e 
)

Co-authored-by: Matt Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Window rolling, ewma, expanding
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback