Skip to content

BUG: MultiIndex.dtypes to handle when no level names #38582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2020
Merged

BUG: MultiIndex.dtypes to handle when no level names #38582

merged 3 commits into from
Dec 21, 2020

Conversation

gurukiran07
Copy link
Contributor

@gurukiran07 gurukiran07 commented Dec 19, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Dec 19, 2020 •
edited
Loading

Hello @gurukiran07! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-19 14:05:47 UTC

@gurukiran07 gurukiran07 mentioned this pull request Dec 19, 2020
Closed
2 tasks
@gurukiran07 gurukiran07 changed the title MultiIndex.dtypes to handle when no level names BUG: MultiIndex.dtypes to handle when no level names Dec 19, 2020
arw2019
arw2019 reviewed Dec 19, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

We'll need a whatsnew (probably under 1.3)

pandas/tests/indexes/multi/test_get_set.py
@@ -45,6 +45,25 @@ def test_get_dtypes():
tm.assert_series_equal(expected, idx_multitype.dtypes)


def test_get_dtypes_no_level_name():
# Test MultiIndex.dtypes (# GH38580 )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit but I'd make this

# GH38580

@arw2019 arw2019 added Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses Needs Review and removed Needs Review labels Dec 19, 2020
@simonjayhawkins
Copy link
Member

We'll need a whatsnew (probably under 1.3)

the feature this PR fixes was added for 1.3 #37073, so release note probably not necessary.

@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Dec 20, 2020
@jreback jreback merged commit 781d998 into pandas-dev:master Dec 21, 2020
@jreback
Copy link
Contributor

jreback commented Dec 21, 2020

thanks @gurukiran07

@gurukiran07 gurukiran07 deleted the mi_dtypes branch December 24, 2020 18:37
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@gurukiran07 @luckyvs1
BUG: MultiIndex.dtypes to handle when no level names (pandas-dev#38582)
c3a9d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arw2019 arw2019 arw2019 left review comments

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: In Multilevel.dtypes when level name is not specified it gives wrong output
5 participants
@gurukiran07 @pep8speaks @simonjayhawkins @jreback @arw2019