Skip to content

DOC:fix of DOCUMENTATION #38579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2020
Merged

DOC:fix of DOCUMENTATION #38579

merged 1 commit into from
Dec 19, 2020

Conversation

Navron4500
Copy link
Contributor

@Navron4500 Navron4500 commented Dec 19, 2020 •
edited by MarcoGorelli
Loading

  • closes DOC: Wrong output in the example of Timedelta.isoformat #38311
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [ Timedelta.isoformat DOC had duplicates i have deleted one of them. And their was two lines with wrong output that i have also fixed.] whatsnew entry

MarcoGorelli
MarcoGorelli approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Please link the issue number next time

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Dec 19, 2020
@MarcoGorelli MarcoGorelli mentioned this pull request Dec 19, 2020
Closed
@Navron4500
Copy link
Contributor Author

OK thanks. I'll make sure to Link the issue number. It was my first time therefore i didn't knew

@MarcoGorelli
Copy link
Member

Thanks @Navron4500 - merging then following Simon's approval

@MarcoGorelli MarcoGorelli merged commit 03e1c89 into pandas-dev:master Dec 19, 2020
@Navron4500 Navron4500 deleted the time-delta branch December 19, 2020 11:01
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@Navron4500 @luckyvs1
DOC:fix of DOCUMENTATION (pandas-dev#38579)
27afd5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

DOC: Wrong output in the example of Timedelta.isoformat
3 participants
@Navron4500 @MarcoGorelli @simonjayhawkins