-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST/REF: io/parser/(test_dtypes.py, test_usecols.py) #38578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
instead of using classes, can you just create / rename more module files? its the same effect. cc @gfyoung |
100% agree with @jreback feedback. Functions are more idiomatic with A module will achieve what you are trying to do with these classes. Otherwise, a custom fixture will do. |
Sgtm - will put these into modules |
looks like something is failing, merge master. pls confrm same number of tests on master as on here. |
I used the same name for a base file between two folders - fixed now |
This patch:
On master:
|
Green |
thanks |
* test reorg * test reorg * split test_dtypes.py into multiple files * split test_usecols.py into multiple files * dedeuplicate base filenames * complete file renaming
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
#38370 adds a pyarrow engine to the csv reader. Only a fraction of the io/parser tests pass when pyarrow is used and the rest has to be xfailed/skipped, resulting in a large diff on the PR.
xref #38370 (comment) suggests reorganizing the tests into classes so groups of tests can be xfailed with a single mark.
I'm grouping the tests logically (not based on whether or not they pass with pyarrow) but merging this this will reduce the diff in #38370 substantively.
Likely I will submit a follow-on with some further reorg. I'm happy to push that to this PR if that's preferred, though.
Verifying that total number of tests is unchanged:
versus on master: