Skip to content

patch wsl compatibility #38546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2020
Merged

patch wsl compatibility #38546

merged 2 commits into from
Dec 23, 2020

Conversation

mbkupfer
Copy link
Contributor

Change wsl check to something more universal and consistent

@simonjayhawkins simonjayhawkins mentioned this pull request Dec 18, 2020
Merged
mroeschke
mroeschke approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I am not sure this can reliably be tested, but confirmed this works on your end?

@mroeschke mroeschke added this to the 1.3 milestone Dec 20, 2020
@mroeschke mroeschke added Windows Windows OS IO Data IO issues that don't fit into a more specific label labels Dec 20, 2020
@mbkupfer
Copy link
Contributor Author

Thanks. I am not sure this can reliably be tested, but confirmed this works on your end?

I see, and yes, it's working for me.

jreback
jreback requested changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mbkupfer

can you add a whatsnew note, 1.3. bug fix for i/o section.
can you open an issue and push this upstream as well

mbkupfer and others added 2 commits December 22, 2020 09:19
@mbkupfer
patch wsl compatibility
7929e89 
Change wsl check to something more universal and consistent
@mbkupfer
update to whatsnew
f060ca6
@simonjayhawkins
Copy link
Member

Thanks. I am not sure this can reliably be tested, but confirmed this works on your end?

I see, and yes, it's working for me.

works for me too.

@mbkupfer
Copy link
Contributor Author

@jreback I've rebased the original commit and added a line in whatsnew. Let me know if you need anything else from my end.

@jreback jreback merged commit 0230d03 into pandas-dev:master Dec 23, 2020
@jreback
Copy link
Contributor

jreback commented Dec 23, 2020

thanks @mbkupfer

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@mbkupfer @luckyvs1
patch wsl compatibility (pandas-dev#38546)
478ab56
@MarcoGorelli MarcoGorelli mentioned this pull request Jan 24, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO Data IO issues that don't fit into a more specific label Windows Windows OS
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: can't use to_clipboard/read_clipboard on WSL 2.0
4 participants
@mbkupfer @simonjayhawkins @jreback @mroeschke