testing case sort_index with pd.set_option('use_inf_as_na', True) #38542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @weikhor! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
arw2019
suggested changes
Dec 17, 2020
| now = pd.Timestamp.now() | ||
| df.index = [now, now - pd.Timedelta('1m'), now + pd.Timedelta('2m')] | ||
|
|
||
| try: |
There was a problem hiding this comment.
(this specific bit doesn't raise so this is a general pointer)
|
@weikhor can you merge master and update to comments |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
closing as stale. if you want to continue, pls ping and can re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffCreate test cases for sort_index works with 'pd.set_option('mode.use_inf_as_na',True)