TYP: pandas/io/sql.py (easy: bool/str) #38537
Conversation
| chunksize: Optional[str], | ||
| columns, | ||
| coerce_float: bool = True, | ||
| parse_dates=None, |
There was a problem hiding this comment.
is this one correct? parse_dates
There was a problem hiding this comment.
I actually didn't touch this, but looking through these read_sql methods parse_dates defaults to None in most (I think all) of those
There was a problem hiding this comment.
maybe i pointed at the wrong one, this shouldn't be a bool type for parse_dates right? it takes a Optional[Dict[str, ....]]
There was a problem hiding this comment.
Ah yes it's one up from here.
Fixed (removed the annotation - sticking to doing plain bool/str in this PR)
pandas/io/sql.py
Outdated
| @@ -77,7 +77,7 @@ def _process_parse_dates_argument(parse_dates): | |||
| return parse_dates | |||
|
|
|||
|
|
|||
| def _handle_date_column(col, utc=None, format=None): | |||
| def _handle_date_column(col, utc: Optional[bool] = None, format: Optional[str] = None): | |||
There was a problem hiding this comment.
format is not right, itls something like Optional[Union[Dict[str, str], str]]
There was a problem hiding this comment.
yes definitely a mistake
I think it has to be Optional[Dict[str, Any]] because it ends up in
to_datetime(col, errors=error, **format)
Can also be str
|
thanks @arw2019 |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff