Skip to content

BUG&TST: HTML formatting error in Styler.render() in rowspan attribute #38533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 22, 2020
Merged

BUG&TST: HTML formatting error in Styler.render() in rowspan attribute #38533

merged 10 commits into from
Dec 22, 2020

Conversation

JoseNavy
Copy link
Contributor

@JoseNavy JoseNavy commented Dec 17, 2020 •
edited
Loading

  • closes #38234
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

pep8speaks commented Dec 17, 2020 •
edited
Loading

Hello @JoseNavy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-22 18:13:36 UTC

@jreback jreback added this to the 1.2 milestone Dec 22, 2020
@jreback jreback added Bug Styler conditional formatting using DataFrame.style labels Dec 22, 2020
jreback
jreback requested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note, bug fixes for 1.2 (add a Styler sub-section after Plotting). merge master and ping on green-ish.

@jreback
Copy link
Contributor

jreback commented Dec 22, 2020

lgtm ping on greenish

@JoseNavy
Copy link
Contributor Author

The Travis check didn't pass and after checking why, I don't see a clear error on what went wrong. All the other checks did pass, can you help me with this? @jreback

@jreback jreback merged commit bb2c10e into pandas-dev:master Dec 22, 2020
@jreback
Copy link
Contributor

jreback commented Dec 22, 2020

thanks @JoseNavy the travis CI is acting up, unrelated

@jreback
Copy link
Contributor

jreback commented Dec 22, 2020

@meeseeksdev backport 1.2.x

@meeseeksmachine meeseeksmachine mentioned this pull request Dec 22, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 22, 2020
@JoseNavy @meeseeksmachine
Backport PR pandas-dev#38533: BUG&TST: HTML formatting error in Style…
00c9550 
…r.render() in rowspan attribute
jreback pushed a commit that referenced this pull request Dec 22, 2020
@meeseeksmachine @JoseNavy
Backport PR #38533: BUG&TST: HTML formatting error in Styler.render()…
fd9670e 
… in rowspan attribute (#38640)

Co-authored-by: JoseNavy <[email protected]>
@simonjayhawkins simonjayhawkins mentioned this pull request Dec 23, 2020
Closed
3 tasks
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@JoseNavy @luckyvs1
BUG&TST: HTML formatting error in Styler.render() in rowspan attribute (
eee1ee8 
pandas-dev#38533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Styler conditional formatting using DataFrame.style
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseNavy @pep8speaks @jreback