Skip to content

BUG: read_excel forward-filling MI names #38517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 1, 2021

Conversation

mzeitlin11
Copy link
Member

Added test with OP's issue as a sheet in the style of existing sheets in tests/io/data/excel/testmultiindex.*

(the same as the "both_name" sheet, but with the cell below the MI name empty)

New sheet looks like:
Screen Shot 2020-12-15 at 9 50 02 PM

In master without this change, the empty cell was being filled with the index name ilvl2

@mzeitlin11 mzeitlin11 added Bug IO Excel read_excel, to_excel labels Dec 25, 2020
@jreback jreback added this to the 1.3 milestone Dec 31, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @WillAyd @gfyoung good here?

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @gfyoung merge whenever you are good with it

@gfyoung gfyoung merged commit ce5a27e into pandas-dev:master Jan 1, 2021
@gfyoung
Copy link
Member

gfyoung commented Jan 1, 2021

Thanks @mzeitlin11 !

@mzeitlin11 mzeitlin11 deleted the bug/ffill_mi_names_excel branch January 1, 2021 20:02
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: read_excel: incorrect multi-index values - 2
4 participants