-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: read_excel forward-filling MI names #38517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gfyoung
merged 10 commits into
pandas-dev:master
from
mzeitlin11:bug/ffill_mi_names_excel
Jan 1, 2021
Merged
BUG: read_excel forward-filling MI names #38517
gfyoung
merged 10 commits into
pandas-dev:master
from
mzeitlin11:bug/ffill_mi_names_excel
Jan 1, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Dec 29, 2020
WillAyd
reviewed
Dec 31, 2020
jreback
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WillAyd
approved these changes
Jan 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @gfyoung merge whenever you are good with it
gfyoung
approved these changes
Jan 1, 2021
Thanks @mzeitlin11 ! |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Added test with OP's issue as a sheet in the style of existing sheets in
tests/io/data/excel/testmultiindex.*
(the same as the "both_name" sheet, but with the cell below the MI name empty)
New sheet looks like:

In master without this change, the empty cell was being filled with the index name
ilvl2