BUG: MultiIndex.equals returning incorrectly True when Indexes contains NaN #38511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 16, 2020
pandas/core/indexes/multi.py
Outdated
| @@ -3454,12 +3454,14 @@ def equals(self, other: object) -> bool: | |||
|
|
|||
| for i in range(self.nlevels): | |||
| self_codes = self.codes[i] | |||
| other_codes = other.codes[i] | |||
| if not np.array_equal(self_codes == -1, other_codes == -1): | |||
There was a problem hiding this comment.
prob could define
self_mask = self_codes == -1
other_mask = other_codes == -1
and use here and L3460 and L3465
There was a problem hiding this comment.
Good point, is probably faster.
Thx
|
thanks @phofl |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffDepending on the expected behavior of align, this may have hidden an additional bug in align in the referenced issue.