-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Series(dt64, dtype="Sparse[object]") #38508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jbrockmendel
wants to merge
5
commits into
pandas-dev:master
from
jbrockmendel:bug-nansafe-dt64-object
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cfbf6bc
BUG: Series(dt64values, dtype=Sparse[object])
jbrockmendel 8990609
CLN: remove unnecessary checks
jbrockmendel 2c44d66
32bit fixup
jbrockmendel 74a6cef
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 5432b8a
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why wouldn't these be Sparse[datetime64[ns]] ? (and equiv for timedelta). do we actually have a usecase for embedding non-object dtypes here? I think this something that we should limit (as we do coercion on non-sparse things if they are datetimelike already this is a big change).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure i understand the question. are you asking why L1521 isnt
ser = Series(arr, dtype="Sparse[datetime64[ns]]")
?Looking at the non-sparse, case
Series(arr, dtype=object)[0]
returns a pydatetime object, so i guess its OK thatSparse[object]
does the same.Really the motivation is to make astype_nansafe with dt64 data behave the same as DatetimeArray.astype and Block._astype so we can share more.