DOC: Corrected Out-of-date list of sort algorithms #38503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you also update the tests in pandas/tests/series/methods/test_sort_index.py to use stable (where we use mergesort), just parameterize a test is prob good enough. |
FullBeardDev
pushed a commit
to FullBeardDev/pandas
that referenced
this pull request
Dec 16, 2020
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
FullBeardDev
pushed a commit
to FullBeardDev/pandas
that referenced
this pull request
Dec 16, 2020
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
FullBeardDev
force-pushed
the
amend-docs-sorting-algos
branch
from
27c15ae to
783a319
Compare
FullBeardDev
pushed a commit
to FullBeardDev/pandas
that referenced
this pull request
Dec 17, 2020
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
FullBeardDev
force-pushed
the
amend-docs-sorting-algos
branch
from
783a319 to
5ebcd52
Compare
Done :) |
|
LGTM, mind fixing up the merge conflict @DonPablo99? |
jreback
reviewed
Dec 23, 2020
| @@ -104,18 +104,13 @@ def test_sort_index_multiindex(self, level): | |||
| res = s.sort_index(level=level, sort_remaining=False) | |||
| tm.assert_series_equal(s, res) | |||
|
|
|||
| def test_sort_index_kind(self): | |||
| @pytest.mark.parametrize("kind", ["quicksort", "mergesort", "heapsort", "stable"]) | |||
There was a problem hiding this comment.
can you make this a fixture (put in the top of this test file is fine) as well.
There was a problem hiding this comment.
Should I just add a fixture or add it and replace the parametrize statements ?
There was a problem hiding this comment.
add a fixture in this file and use it
|
can you merge master and update |
FullBeardDev
force-pushed
the
amend-docs-sorting-algos
branch
from
5ebcd52 to
9ebdbb2
Compare
FullBeardDev
pushed a commit
to FullBeardDev/pandas
that referenced
this pull request
Dec 29, 2020
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
jreback
requested changes
Dec 29, 2020
| @@ -104,18 +104,13 @@ def test_sort_index_multiindex(self, level): | |||
| res = s.sort_index(level=level, sort_remaining=False) | |||
| tm.assert_series_equal(s, res) | |||
|
|
|||
| def test_sort_index_kind(self): | |||
| @pytest.mark.parametrize("kind", ["quicksort", "mergesort", "heapsort", "stable"]) | |||
Reference Issues/PRs Fixes: pandas-dev#38287 Implemented changes: Changed the docstring of all the methods using np.sort as it now includes one additional stable algorithm
FullBeardDev
pushed a commit
to FullBeardDev/pandas
that referenced
this pull request
Dec 30, 2020
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
FullBeardDev
force-pushed
the
amend-docs-sorting-algos
branch
from
9ebdbb2 to
d5e64c9
Compare
FullBeardDev
pushed a commit
to FullBeardDev/pandas
that referenced
this pull request
Dec 30, 2020
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
FullBeardDev
force-pushed
the
amend-docs-sorting-algos
branch
from
d5e64c9 to
19d04d6
Compare
FullBeardDev
pushed a commit
to FullBeardDev/pandas
that referenced
this pull request
Dec 30, 2020
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
FullBeardDev
force-pushed
the
amend-docs-sorting-algos
branch
from
19d04d6 to
3d0ddc0
Compare
Addition to doc Fix PR: pandas-dev#38503 Implemented changes: Parameterized tests with addition of the newly supported sorting method stable from numpy 1.15.0
FullBeardDev
force-pushed
the
amend-docs-sorting-algos
branch
from
3d0ddc0 to
16bb784
Compare
jreback
approved these changes
Dec 30, 2020
|
thanks @DonPablo99 |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes: #38287
Implemented changes:
Changed the docstring of all the methods using np.sort as it now includes one additional stable algorithm