TST: don't use global fixture in the base extension tests #38494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
the
Testing
|
thanks @jorisvandenbossche |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 15, 2020
…se extension tests
simonjayhawkins
pushed a commit
that referenced
this pull request
Dec 15, 2020
…on tests (#38500) Co-authored-by: Joris Van den Bossche <[email protected]>
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #37867. In the discussion about using this fixture, I forgot that we should not use global pandas fixtures in those tests, but only the ones that are defined in the local /pandas/tests/extension/conftest.py, otherwise this doesn't work for downstream projects (eg geopandas/geopandas#1735). For this case it's easier to simply not use a fixture, I think (but still share the common definition of the list)