BUG: disallow scalar in Categorical constructor #38472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also easily deprecate this first. I don't know if others would rely on it, but at least we did ourselves (the behaviour was explicitly tested) |
|
indifferent here. am ok pushing this thru or deprecating. |
|
doesn't this duplicate #38614 (or vice versa) |
no. one is for Categorical, the other for CategoricalIndex |
ok. should we deprecate this? i agree its very weird, but i suppose it might happen in the real world. |
|
Given that we had tests for it, and that it is actually also allowed for Series, I would go for deprecation first (it shouldn't be hard I think?) |
jorisvandenbossche
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff