REF: simplify _sanitize_column #38459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 14, 2020
pandas/core/frame.py
Outdated
| @@ -3210,15 +3212,47 @@ def _setitem_frame(self, key, value): | |||
| self._check_setitem_copy() | |||
| self._where(-key, value, inplace=True) | |||
|
|
|||
| def _set_item_frame_value(self, key, value: "DataFrame"): | |||
pandas/core/frame.py
Outdated
| # reindex if necessary | ||
|
|
||
| if value.index.equals(index) or not len(index): | ||
| value = value._values.copy() |
pandas/core/frame.py
Outdated
| else: | ||
|
|
||
| # GH#4107 | ||
| try: |
| return value | ||
|
|
||
|
|
||
| def _maybe_atleast_2d(value): |
There was a problem hiding this comment.
could put in core/dtypes/cast
There was a problem hiding this comment.
ill take a look; most likely place it would be used is in internals
jreback
added
Refactor
jreback
approved these changes
Dec 14, 2020
|
thanks, yeah we have a lot of built up code over the years. +1 on organizaing / simplifying. |
Closed
5 tasks
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It gets called indirectly from
iloc._setitem_with_indexer, which we're trying to simplify