-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: read_csv not recognizing numbers appropriately when decimal is set #38420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f49d007
BUG: read_csv not recognizing numbers appropriately when decimal is set
phofl cc7dd1b
Add corner case
phofl 189ca80
Add another corner case
phofl 567423f
Run black
phofl ba163cf
Fix pep8 issue
phofl a5e568b
Fix pep8
phofl 8dc8cb7
Merge branch 'master' into 31920
phofl b98954b
Merge branch 'master' into 31920
phofl 514f45a
Refactor code
phofl c20767b
Merge branch 'master' of https://github.com/pandas-dev/pandas into 31920
phofl d8d94af
Merge branch '31920' of https://github.com/phofl/pandas into 31920
phofl a0eced5
Update pandas/tests/io/parser/test_python_parser_only.py
phofl efd78d7
Merge branch 'master' of https://github.com/pandas-dev/pandas into 31920
phofl e9d08c4
Merge branch '31920' of https://github.com/phofl/pandas into 31920
phofl a611dad
Fix black bug from autocommit
phofl 9ec9954
Modify whatsnew
phofl 56e7702
Merge branch 'master' of https://github.com/pandas-dev/pandas into 31920
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry wrong commit button above. C works perfectly here. Already have tests therefore. Would probably makes sense unifying them as a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO would do it in this PR, but follow-up also works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine as a followup