ENH: add figsize argument to DataFrame and Series hist methods #3842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jreback ok with this? |
|
don't we always just pass kwds to matplotlib anyhow? (I am not disagreeing with this, because its nice |
|
yes but they weren't being propagated correctly because they were being passed into funcs that don't use them e.g., grouped_hist. plus hist_series was calling gca which creates a figure before u can give it a figsize. u might be able to adjust that post creation but my method requires less mpl api munging |
|
oh i just saw something that i need to change can't merge yet.. |
|
minor point, figsize is in inches I think? (subject to dpi), (may want to mention that) |
|
units there are customizable i believe but ok |
|
@jreback this is good 2 go...shall i merge? |
|
ok |
cpcloud
added a commit
that referenced
this pull request
Jun 12, 2013
ENH: add figsize argument to DataFrame and Series hist methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3834