-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add method argument to rolling constructor to allow table-wise rolling #38417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 46 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
26b29dc
Add method keyword and validation
7739b57
Add sub numba table func
8d66fc4
Fix output result and result min_periods handling
db39381
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
b67e725
Fix cache key
ea89fb6
Just use transpose for axis = 1
87570ef
Add test comparing column and table methods
1477004
Test invalid series table rolling
c377186
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
9bd2d0d
Adjust some tests
9be922b
Add test for invalid method keyword
a6473a5
Notimplemented test with win_type
4fa7abd
wrap table method tests in a class
2d7a58e
Add method keyword for expanding
76ead37
Change caching key to handing callers from Rolling or Expanding
12e7c57
Test expanding table
93c546e
Change column to single
1eaad79
flake8
c550d8e
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
5d040d0
Add weighted mean example as a test
57fc525
black
84619a1
Add whatsnew and window.rst example
42af1c3
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
9f172bd
Add as of version to table
cfe909c
Fix typo and add wikipedia link in window.rst
884c7ff
Use correct type and document func output and input
08f23e0
Newline
27e9bbb
Plural -> singular
b4fa92c
Add noqa in rst
354c698
Skip if scipy isnt installed
6fdfef4
Add asv benchmark
72e50d3
Add min periods for min version build
bdd600c
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
d9aa45c
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
c769ea2
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
dde4d8e
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
b863dc2
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
c674b97
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
55f44af
Remove redundant 1.3 doc
24a80db
Remove closed and center parameterizations
0203d02
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
ba86276
Clarify doc
mroeschke 1651616
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
mroeschke 55156cd
Fix benchmark
mroeschke 6ca999a
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
mroeschke 388b837
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
mroeschke f4ba0c6
just use prange
mroeschke d37e23b
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
mroeschke 9ad8064
Forgot decorator as part of merge conflict fixup
mroeschke d5eb31c
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
mroeschke 754d71e
Merge remote-tracking branch 'upstream/master' into feature/rolling_t…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is method not used in this one? so we're re-doing the same benchmark twice? (not a deal-breaker asi think this happens in a number of places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I think I put the parameterization in the wrong place. Thanks