REF: move __array_ufunc__ to base NumericArray #38412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Refactor
10 tasks
|
mypy complaint, otherwise nice code sharing! |
|
@jorisvandenbossche can you merge master |
|
can you merge master |
|
Updated, and mypy is happy now |
|
thanks @jorisvandenbossche |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #38110
The implementations for integer and float array is almost identical, so move to base class. In addition, this also enables that ufuncs on IntegerArray can return FloatingArray (instead of float numpy array)
I should probably consolidate the tests as well, and move those to
tests/arrays/masked/test_ufunc.pyor so.In addition,
BooleanArray.__array_ufunc__is actually also very similar, but didn't include that here, yet. I should probably do that, but wondering if I should move the common__array_ufunc__implementation to BaseMaskedArray, or rather make BooleanArray subclass NumericArray.