BUG: read_csv interpreting NA value as comment when NA contains comment string #38392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sep, usecols and parse_dates
…decimal sep, usecols and parse_dates" This reverts commit 8c2e1ca
ivanovmg
approved these changes
Dec 10, 2020
Comment on lines
324
to
329
| data = ( | ||
| "# this is a comment\n" | ||
| "1,2,3,4\n" | ||
| "1,2,3,4#inline comment\n" | ||
| "1,2#,3,4\n" | ||
| "1,2,#N/A,4\n" |
There was a problem hiding this comment.
Would it be better to have the first row (not the commented one) to be like ``col_1,col_2,col_3,col4\n" to avoid confusion with the values below it?
|
looks fine here. can you merge master. cc @gfyoung if any comments. |
gfyoung
reviewed
Dec 12, 2020
gfyoung
reviewed
Dec 12, 2020
gfyoung
approved these changes
Dec 13, 2020
|
can u merge master and ping on green |
|
@jreback green |
|
thanks @phofl |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…nt string (pandas-dev#38392) * BUG: read_csv not converting to float for python engine with decimal sep, usecols and parse_dates * Fix comment issues for python parser * Add test * Add whatsnew * Revert "BUG: read_csv not converting to float for python engine with decimal sep, usecols and parse_dates" This reverts commit 8c2e1ca * Commit merge conflict * Improve test * Remove import * Add c tests * Remove function input * Improve note Co-authored-by: Jeff Reback <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI looked into the
ccase, but this is not that trivial as here. Comments are removed way before checking for na values. Would have to move that part way down to be able to do this.